AsyncDisplayKit icon indicating copy to clipboard operation
AsyncDisplayKit copied to clipboard

Expected method to read dictionary element not found on object of type 'id<NSObject>'

Open puyangdev opened this issue 6 years ago • 3 comments

ASDefaultPlaybackButtonType buttonType = (ASDefaultPlaybackButtonType)[parameters[@"buttonType"] intValue]; UIColor *color = parameters[@"color"];

Expected method to read dictionary element not found on object of type 'id<NSObject>'

puyangdev avatar Sep 28 '18 02:09 puyangdev

@puyangdev AsyncDisplayKit was renamed to Texture, check out https://github.com/TextureGroup/Texture

ay8s avatar Oct 17 '18 00:10 ay8s

@ay8s there is this pull request opened from August that fixes this issue https://github.com/facebookarchive/AsyncDisplayKit/pull/3310 if @SkyOfFeather didn't sign the https://code.facebook.com/cla maybe you can just make the change? this is a change in the declaration from (id<NSObject>) to (NSDictionary *) Although upgrading to Texture is better but will be harder in big codebase. Thanks

avipinto avatar Oct 17 '18 14:10 avipinto

Unfortunately no PR's will be accepted here. Best to upgrade as theres been years of improvements since. There shouldn't be too many code breaking changes to work through.

ay8s avatar Jan 14 '19 21:01 ay8s