Rename {clean-all,uninstall} targets -> zstd_{clean-all,uninstall}

[jbms]

This avoids target namespace pollution when including zstd as a sub-project.

[facebook-github-bot]

Hi @jbms!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[yoniko]

Hi @jbms , Thank you for your contribution, I'm not a CMake expert but I don't feel comfortable with the solution - it changes an interface that other users may depend on. Additionally, it seems redundant to have the library name as part of a prefix for the command. I think a better solution would be something similar to gflag's solution, where they don't add the commands if included as a subproject.

They allow the user to set a flag if the project is a subproject and if it doesn't exist, they autodetect: https://github.com/gflags/gflags/blob/master/CMakeLists.txt#L134. I think a similar solution would be significantly better.

[yoniko]

Added an issue to implement the flag based solution (#3468). Closing this PR.