zstd icon indicating copy to clipboard operation
zstd copied to clipboard

drop -E flag in sed

Open haampie opened this issue 3 years ago • 3 comments

This flag is not universally supported in sed, and there's no regex replacement going on anwyays, it's literal text replacement.

-E is missing in sed version 4.1.5 for example, as found on some ancient centos image I'm working with.

haampie avatar Aug 19 '22 10:08 haampie

Hi @haampie!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Aug 19 '22 10:08 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Aug 19 '22 12:08 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Aug 19 '22 12:08 facebook-github-bot