zstd
zstd copied to clipboard
Improve and Move Windows Artifact Generation to GitHub Actions
It seems like every release we make some kind of little mistake with the naming or contents of the windows artifacts. See #3012 and #3001 recently.
We should improve our automation here. Moving this workflow to GitHub Actions would allow us to publish the artifacts to the release automatically, removing opportunities for error. This would also advance our broad goal of moving contbuild work off of Appveyor and onto GitHub.
It also came up in discussion that it might be convenient to provide both the full existing .zip as well as a binary-only artifact. So this work item should resolve that.
Moving to GitHub Actions would also allow us to sign those artifacts.
Currently, the files in dll
and static
folders are generated by Cygwin (or MinGW), not MSVC.
Do you want to use MSVC to build instead?
Is zstd.exe
also generated by Cygwin (or MinGW)?
@felixhandte do you intend to do this before the release?
We do currently have https://github.com/facebook/zstd/blob/dev/.github/workflows/windows-artifacts.yml . Does it fulfill the objectives of this PR, or are there additional details wanted ?