stylex icon indicating copy to clipboard operation
stylex copied to clipboard

Published 20 hours ago • verified publisher icon facebook

feat: add `esm` bundle to `@stylexjs/stylex`

Open nedjulius opened this issue 1 year ago • 7 comments

What changed / motivation ?

This PR modifies the build script of stylex and adds ECMAScript module support for the package.

Linked PR/Issues

Fixes #205

Pre-flight checklist

  • [x] I have read the contributing guidelines Contribution Guidelines
  • [x] Performed a self-review of my code

nedjulius avatar Dec 19 '23 07:12 nedjulius

This looks good so far. LMK, when you think it's ready for review.

nmn avatar Dec 19 '23 10:12 nmn

@nmn yeah, I think it's ready now!

nedjulius avatar Dec 19 '23 17:12 nedjulius

Thank you @nedjulius! It looks good to merge, but I'm checking some things and will merge in a few days. I'll make sure to include this in the next point release.

nmn avatar Dec 20 '23 07:12 nmn

I think this not enough, the upstream package you are using is still cjs. Which will still break the build

himself65 avatar Dec 20 '23 09:12 himself65

@himself65 Yes, I'm aware which is what I'm going to be fixing over the next few days!

nmn avatar Dec 20 '23 09:12 nmn

@nmn are you looking into fixing the upstream package issue? I can try to look into it as well so we can unblock this PR

nedjulius avatar Dec 27 '23 20:12 nedjulius

@nedjulius Yes, I have a PR up already. There's a couple of errors I hope to fix soon.

nmn avatar Dec 27 '23 20:12 nmn