stylex icon indicating copy to clipboard operation
stylex copied to clipboard

[eslint-plugin] Split up `valid-styles`

Open mellyeliu opened this issue 4 months ago • 2 comments

Constant ask from ESLint folks. Most common complaint with linting is that valid-styles as a rule is not descriptive and difficult to understand. It handles a lot of things: property validation, type checking, object structure validation, pseudo-selectors and at-rules, border shorthand expansion, and converts nonstandard properties to current ones.

There's also some duplication with valid-shorthands.

Let's consolidate and split up logic where it makes sense. There are some ESLint perf regressions from scanning styles multiple times so let's think through what makes sense

mellyeliu avatar Aug 19 '25 00:08 mellyeliu

This got closed when landing the first merge, this issue is still open and in development.

jcperez-ch avatar Sep 18 '25 20:09 jcperez-ch

i think the git ui scans for "Fixes XXX" and closes regardless :D

mellyeliu avatar Sep 18 '25 21:09 mellyeliu