sapp icon indicating copy to clipboard operation
sapp copied to clipboard

Fix Pyre GitHub Action

Open WangGithubUser opened this issue 1 year ago • 0 comments

Pre-submission checklist

  • [x] I've ran the following linters locally and fixed lint errors related to the files I modified in this PR
    • [x] black .
    • [x] usort format .
    • [x] flake8
  • [ ] I've installed dev dependencies pip install -r requirements-dev.txt and completed the following:
    • [ ] I've ran tests with ./scripts/run-tests.sh and made sure all tests are passing

Nope, sorry.I'm on Windows platform and my virtual machine crashed.But this test will run in GitHub Action tests and we can see if this workflow is successful.(also, this PR shouldn't cause any lint error)

Summary

Pyre workflow failed in this repo for two reasons:

  1. We need to provide a is_toplevel_module for typing_extensions, as this PR.
  2. ujson also couldn't found caused by a known issue of Pyre: facebook/pyre-check#773

Test Plan

If this PR merged and the issue above fixed, pyre Action workflow should pass.

WangGithubUser avatar Aug 11 '23 01:08 WangGithubUser