sapling icon indicating copy to clipboard operation
sapling copied to clipboard

[ReviewStack] Missing commit/PR versions on ReviewStack

Open equetzal opened this issue 1 year ago • 2 comments

Context

Review Stack have a feature for switching the commit version: Captura de pantalla 2023-06-02 a la(s) 7 58 01 a m

Problem

Even if more versions are pushed and even detected by ReviewStack history, ReviewStack does not display this versions on the version dropbox and does only shows the very first version. Captura de pantalla 2023-06-02 a la(s) 8 00 29 a m

I've been able to reproduce this several times by sending a commit as a PR, amending the commit and the submitting it to Github again, the force pushed is accurately handled by github, but not by ReviewStack.

Expected Behavior

I would expect ReviewStack to load the last version instead of the first, as this makes more sense to review the last one. I would also expect ReviewStack to properly load the versions and allow switching between them as currently possible on Phabricator.

equetzal avatar Jun 02 '23 14:06 equetzal

I think it should be solved by #656

sggutier avatar Jun 26 '23 21:06 sggutier

probably also needs #684

ahornby avatar Jul 23 '23 11:07 ahornby