sapling icon indicating copy to clipboard operation
sapling copied to clipboard

Don't repeat title in body of GitHub PR

Open steveluscher opened this issue 1 year ago • 2 comments

Given a commit of this form:

TITLE

Summary: SUMMARY

Test Plan: TEST_PLAN

Observed behavior

sl pr submit creates a PR with the title TITLE but also repeats that title in the PR description.

Expected behavior

sl pr submit should omit the title from the PR description.

Example PR.

steveluscher avatar Mar 17 '23 18:03 steveluscher

I actually like this behavior 🤷‍♂️

vegerot avatar Mar 20 '23 21:03 vegerot

On second thought, this feature will be helpful for projects with a required PR Template. I cannot simply use the .github/PULL_REQUEST_TEMPLATE.md because it copies the commit title to the top of the PR description

vegerot avatar Jun 19 '23 18:06 vegerot