sapling icon indicating copy to clipboard operation
sapling copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Adds support for providing custom PR string template in config

Open discentem opened this issue 2 years ago • 4 comments

Adds support for providing custom PR string template in config

Stack created with Sapling. Best reviewed with ReviewStack.

  • -> #524

discentem avatar Feb 07 '23 07:02 discentem

@quark-zju has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Feb 15 '23 21:02 facebook-github-bot

Chatted with @quark-zju on Discord -- I should redo this PR using the native template engine

https://discord.com/channels/1042527964224557107/1042527965256364157/1120945622892159078

https://github.com/facebook/sapling/blob/main/eden/scm/edenscm/cmdutil.py#L1080

discentem avatar Jun 25 '23 00:06 discentem

Any updates on this, would nice to have

ghost avatar Oct 25 '23 16:10 ghost

In discussing with maintainers, I need to redo the PR using the template framework that Sapling ships with. I honestly have no idea when I get around to it. If you want to take a stab, feel free to do so.

Right now my primary usage of Sapling is in my own open source repo so I haven’t needed the custom template stuff in a while.

On Wed, Oct 25, 2023 at 09:31 Dillon Mulroy @.***> wrote:

Any updates on this, would nice to have

— Reply to this email directly, view it on GitHub https://github.com/facebook/sapling/pull/524#issuecomment-1779648552, or unsubscribe https://github.com/notifications/unsubscribe-auth/AATRDMCEXOBER2WPSBLKBCDYBE5FZAVCNFSM6AAAAAAUTSWLX2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONZZGY2DQNJVGI . You are receiving this because you authored the thread.Message ID: @.***>

discentem avatar Oct 25 '23 17:10 discentem