sapling icon indicating copy to clipboard operation
sapling copied to clipboard
verified publisher icon facebook

Documentation for replacement to the `phase` command: preventing a commit from becoming a PR

Open lfousse opened this issue 3 years ago • 2 comments

I tried the following to mark my current commit as secret which I understand to mean that it won't be pushed to GitHub (my remote) as a PR:

$ sl phase -s
(phases are now managed by remotenames and heads; manully editing phases is a no-op)

I didn't find documentation related to remotenames. What's the best way to prevent a commit from getting pushed as a PR?

lfousse avatar Dec 22 '22 15:12 lfousse

Could you provide more context why you want to prevent a commit from getting pushed as a PR? Is the commit in the middle of a stack with other commits?

zzl0 avatar May 13 '25 11:05 zzl0

The situation would be that I have a commit pushed as a PR, and while it is being reviewed, I am working on another feature on top of that PR. Those descendant commits should not be part of the same PR, and may not yet be ready for review as their own PR yet. Marking them "secret" would prevent an accidental upload.

lfousse avatar May 17 '25 15:05 lfousse