sapling
sapling copied to clipboard
Reverse order of branch names
When submitting multiple PRs from Sapling CLI, branches on GitHub are created in reverse order.
Example: submitted three PRs and got:
- https://github.com/sheremetyev/sapling-test-1/pull/1 has branch name "pr3"
- https://github.com/sheremetyev/sapling-test-1/pull/3 has branch name "pr1"
Steps to reproduce:
-
create a new repository on GitHub
-
clone repository
$ sl clone https://github.com/sheremetyev/sapling-test-1.git
$ cd sapling-test-1
- create several commits
$ echo foo > foo.txt ; sl add foo.txt ; sl ci -m 'adding foo'
$ echo bar > bar.txt ; sl add bar.txt ; sl ci -m 'adding bar'
$ echo baz > baz.txt ; sl add baz.txt ; sl ci -m 'adding baz'
- submit multiple PRs at once
$ sl pr
- check names of branches in the created PRs on GitHub
Expected: branch names suffixes match PR numbers Actual: bottommost PRs in the stack has lowest PR number but highest branch number
Environment: macOS arm64
Sapling installed as described at https://sapling-scm.com/docs/introduction/installation#apple-silicon-arm64
$ sl --version
Sapling 0.1.20221118-210929-cfbb68aa
Thanks for filing! I discovered on Friday that I regressed this recently. Will fix!
We plan to do a new release this morning with this fix!