sapling icon indicating copy to clipboard operation
sapling copied to clipboard

Restart sl daemon after ulimit changes

Open nataliejameson opened this issue 3 years ago • 4 comments

I hadn't set the open files limit with ulimit before running an sl clone. After running the clone, I hit the open file limit issue that is mentioned in the installation docs. So, I set ulimit in my .bash_profile, but was still running into issues. Turns out I had forgotten to kill the sl daemon that was started with the old limits.

Is there any way we can detect that and either restart the daemon gracefully, or at least warn about it? It seems like it might be a bit non-obvious that there even is a daemon running, so it could be an annoyance. Maybe even just making it an sl doctor feature would be enough.

nataliejameson avatar Nov 18 '22 07:11 nataliejameson

I just ran into this issue this morning. Thank you for submitting the issue; I had no idea a daemon was even involved and was very confused as to why my new ulimit wasn't seeming to take effect.

neutralinsomniac avatar Nov 18 '22 16:11 neutralinsomniac

Not a solution, but sl --kill-chg-daemon should at least stop it without having to hunt for it through the process table.

rbehrends avatar Nov 18 '22 17:11 rbehrends

@wez this probably explains what you ran into?

bolinfest avatar Nov 19 '22 01:11 bolinfest

@bolinfest ah! I'd forgotten about chg, yeah, that makes sense

wez avatar Nov 19 '22 02:11 wez