sapling icon indicating copy to clipboard operation
sapling copied to clipboard

Fix missing extern for identity crate

Open yonas opened this issue 2 years ago • 2 comments

yonas avatar Nov 16 '22 14:11 yonas

Posted this too early. I'm now getting a cant' find crate error when running make oss, but compiling hgmain works when I go into it's directory (eden/scm/exec/hgmain) and run cargo build --release.

yonas avatar Nov 16 '22 14:11 yonas

I'm not sure what issue you're hitting. Possibilities:

  • Do you need to make clean and then make oss again?
  • Are you on an M1? For our prebuilt binaries, we cross-compile from Intel Mac, so building on M1 directly isn't tested quite as well.

bolinfest avatar Nov 19 '22 05:11 bolinfest

Are you using an old rustc? extern crate became unnecessary since Rust edition 2018: https://doc.rust-lang.org/edition-guide/rust-2018/path-changes.html#no-more-extern-crate and we're targeting Rust edition 2021 now. I'm closing this since upgrading rustc seems to solve this issue.

quark-zju avatar Nov 23 '22 23:11 quark-zju