sapling icon indicating copy to clipboard operation
sapling copied to clipboard

Releases names are unreadable/non-standard

Open Pranav-yadav opened this issue 2 years ago • 1 comments

Note: Looks like SemVer isn't being followed

Current:

20221115-080554-34470671

Expected:

Should use proper SemVer or more readable release/tag names Ex.;

2.0.2-alpha
major.minor.patch-build

Cause:

https://github.com/facebook/sapling/blob/aaaa8275d7b1e1325ed1283e18bf7a1d0653f46a/.github/workflows/TagIt.yml#L37

Pranav-yadav avatar Nov 15 '22 19:11 Pranav-yadav

I would also recommend avoiding dashes, as it causes issues when packaging this for Linux distributions.

davide125 avatar Nov 15 '22 21:11 davide125

Working on it: https://github.com/facebook/sapling/pull/208

Though I believe we plan to make use of dashes. Example:

0.1.20221117-115420-91bf257e

bolinfest avatar Nov 19 '22 00:11 bolinfest