sapling icon indicating copy to clipboard operation
sapling copied to clipboard

feat(oss): Support thrift-py3/thrift-rust and improve python support for c++ inclusion

Open ben-- opened this issue 5 months ago • 1 comments

Three separate improvements needed by the OSS Sapling/EdenFS build:

  1. Add LANGUAGES py3 support to add_fbthrift_library() in make
  2. Add LANGUAGES rustsupport to add_fbthrift_library() in cmake
  3. Add cython support in cmake
  4. Add ability for python binaries to support non-python dependencies (needed by cython)
  5. Switch rust to the nightly build to support #[deprecated]

Tested through building Sapling/EdenFS (requires other fixes to run clean):

act --container-architecture linux/x86_64 -W .github/workflows/edenfs_linux.yml

ben-- avatar Sep 22 '25 22:09 ben--

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D83008904. (Because this pull request was imported automatically, there will not be any future comments.)

facebook-github-bot avatar Sep 22 '25 22:09 facebook-github-bot