rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

CompactionOutputs::Finish: sync FileMeta with TableProperties

Open rockeet opened this issue 4 years ago • 4 comments

the output file meta may be used later.

rockeet avatar Oct 12 '21 07:10 rockeet

I mostly understand this change (I think) but either I am missing something or the title does not agree with the code. Are you syncing the TableProperties to the FileMeta (as the title suggests) or the meta to the properties (as the code suggests)?

I see that this change could be important/useful, but what problem is it solving? Can you add a test to show something that this fix addresses?

  1. I have fixed the title
  2. We have a in house branch of rocksdb which added a compaction.output.file.raw.size histogram, we use meta.raw_key_size + meta.raw_value_size as the histogram value, then we saw the histogram is always zero, which was caused by this bug. So I can't provide a minimal test case for this fix.

rockeet avatar Oct 13 '21 05:10 rockeet

Is there any progress?

rockeet avatar Jun 23 '22 13:06 rockeet

Please look into the test failures - thanks!

hx235 avatar Dec 29 '23 22:12 hx235

Please look into the test failures - thanks!

Fixed, the cause was missing num_range_deletions.

rockeet avatar Jan 02 '24 05:01 rockeet