CompactionOutputs::Finish: sync FileMeta with TableProperties
the output file meta may be used later.
I mostly understand this change (I think) but either I am missing something or the title does not agree with the code. Are you syncing the TableProperties to the FileMeta (as the title suggests) or the meta to the properties (as the code suggests)?
I see that this change could be important/useful, but what problem is it solving? Can you add a test to show something that this fix addresses?
- I have fixed the title
- We have a in house branch of rocksdb which added a
compaction.output.file.raw.sizehistogram, we usemeta.raw_key_size + meta.raw_value_sizeas the histogram value, then we saw the histogram is always zero, which was caused by this bug. So I can't provide a minimal test case for this fix.
Is there any progress?
Please look into the test failures - thanks!
Please look into the test failures - thanks!
Fixed, the cause was missing num_range_deletions.