rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

Ambiguous license notice in code files

Open pombredanne opened this issue 5 years ago • 7 comments

Code files have this type of notice:

//  This source code is licensed under both the GPLv2 (found in the
//  COPYING file in the root directory) and Apache 2.0 License
//  (found in the LICENSE.Apache file in the root directory).

Taken alone such a notice is a tad ambiguous? do both the GPL AND the Apache license apply at the same time? or is this choice?

Of course the README makes this clear that this is a choice (e.g. OR, not AND):

License

RocksDB is dual-licensed under both the GPLv2 (found in the COPYING file in the root directory) and Apache 2.0 License (found in the LICENSE.Apache file in the root directory). You may select, at your option, one of the above-listed licenses.

It would be great to have clear source code-level notices.

This has been found by @royaljust

pombredanne avatar May 20 '19 21:05 pombredanne

Any progress on this issue? I believe it should be a relatively straightforward task that can be quickly addressed.

silence-coding avatar Apr 22 '24 13:04 silence-coding

Any progress on this issue? I believe it should be a relatively straightforward task that can be quickly addressed.

heilengleng avatar Apr 23 '24 03:04 heilengleng

@ramvadiv This issue has caused me the same confusion. Please handle it, thanks.

lidong14 avatar Apr 23 '24 03:04 lidong14

@ajkr Sorry to bother you, but I noticed you've been involved in multiple discussions about licensing. I'd like to ask who can handle this issue? It seems the delegate has been inactive for quite some time.

silence-coding avatar Apr 23 '24 03:04 silence-coding

Any progress on this issue? I believe it should be a relatively straightforward task that can be quickly addressed.

Changing the source file license text of a large company's open source project sounds extremely unlikely to be straightforward. I can't offer anything more than a referral to the README: "RocksDB is dual-licensed under both the GPLv2 (found in the COPYING file in the root directory) and Apache 2.0 License (found in the LICENSE.Apache file in the root directory). You may select, at your option, one of the above-listed licenses." I do not know who can offer more than that.

ajkr avatar Apr 23 '24 05:04 ajkr

According to the definition of SPDX

If required to simultaneously comply with two or more licenses, use the conjunctive binary "AND" operator to construct a new license expression, where both the left and right operands are a valid license expression values.

Most of the file header is

//  Copyright (c) 2011-present, Facebook, Inc.  All rights reserved.
//  This source code is licensed under both the GPLv2 (found in the
//  COPYING file in the root directory) and Apache 2.0 License
//  (found in the LICENSE.Apache file in the root directory).
//

It may caues some confusion when trying to partially introduce code.

y2361547758 avatar Apr 23 '24 10:04 y2361547758

Any progress on this issue? I believe it should be a relatively straightforward task that can be quickly addressed.

Changing the source file license text of a large company's open source project sounds extremely unlikely to be straightforward. I can't offer anything more than a referral to the README: "RocksDB is dual-licensed under both the GPLv2 (found in the COPYING file in the root directory) and Apache 2.0 License (found in the LICENSE.Apache file in the root directory). You may select, at your option, one of the above-listed licenses." I do not know who can offer more than that.

You're probably right. For large-scale projects, such modifications would likely entail significant review costs. However, I believe the risk of bulk license replacement should be manageable.

silence-coding avatar Apr 25 '24 02:04 silence-coding