I met compilation error on apple-clang 15. Error messages are following:

In file included from table/block_based/block_based_table_builder.cc:10:
In file included from table/block_based/block_based_table_builder.h:17:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/c++/v1/vector:321:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/c++/v1/__format/formatter_bool.h:20:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/c++/v1/__format/formatter_integral.h:32:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/c++/v1/locale:202:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/c++/v1/__locale:15:
In file included from /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/c++/v1/__memory/shared_ptr.h:31:
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/c++/v1/__memory/unique_ptr.h:66:19: error: invalid application of 'sizeof' to an incomplete type 'rocksdb::BlockBasedTableBuilder::ParallelCompressionRep'
    static_assert(sizeof(_Tp) >= 0, "cannot delete an incomplete type");
                  ^~~~~~~~~~~
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/c++/v1/__memory/unique_ptr.h:300:7: note: in instantiation of member function 'std::default_delete<rocksdb::BlockBasedTableBuilder::ParallelCompressionRep>::operator()' requested here
      __ptr_.second()(__tmp);
      ^
/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX14.5.sdk/usr/include/c++/v1/__memory/unique_ptr.h:266:75: note: in instantiation of member function 'std::unique_ptr<rocksdb::BlockBasedTableBuilder::ParallelCompressionRep>::reset' requested here
  _LIBCPP_INLINE_VISIBILITY _LIBCPP_CONSTEXPR_SINCE_CXX23 ~unique_ptr() { reset(); }
                                                                          ^
table/block_based/block_based_table_builder.cc:448:3: note: in instantiation of member function 'std::unique_ptr<rocksdb::BlockBasedTableBuilder::ParallelCompressionRep>::~unique_ptr' requested here
  Rep(const BlockBasedTableOptions& table_opt, const TableBuilderOptions& tbo,
  ^
table/block_based/block_based_table_builder.h:162:10: note: forward declaration of 'rocksdb::BlockBasedTableBuilder::ParallelCompressionRep'
  struct ParallelCompressionRep;
         ^

This issue is caused by the positions defined between BlockBasedTableBuilder::Rep and BlockBasedTableBuilder::ParallelCompressionRep. This PR switches these positions to resolve this issue.

Sep 09 '24 04:09 toge

Hi @toge!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Sep 09 '24 04:09 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sep 09 '24 04:09 facebook-github-bot

I met the same compilation error too on Ubuntu clang version 19 to compile rocksdb any version 9.x.x from conan package or git clone from this repository. I had to modify struct BlockBasedTableBuilder::ParallelCompressionRep to struct BlockBasedTableBuilder::Rep ahead and compile modified source and link local libary in my project. Is the issue fixed PR merged to the newest version ? @toge

Nov 18 '24 05:11 pengybhnu

This is still happening on rocksdb 9.10.0 with clang libc++ 19

Feb 26 '25 03:02 RazielXYZ

Experiencing on Amz Linux 2023 (fedora)

With this fix, I'm now getting

table/block_based/block_based_table_builder.cc:813:48: error: use of undeclared identifier 'kZSTDNotFinalCompression'
  813 |                            compression_type == kZSTDNotFinalCompression,
      |                                                ^
/tmp/eugo/rocksdb-24e2b05e6179fda5770f3a4203fa7cdfda7fd936/table/block_based/block_based_table_builder.cc:1962:40: error: use of undeclared identifier 'kZSTDNotFinalCompression'
 1962 |                 r->compression_type == kZSTDNotFinalCompression));
      |                                        ^
2 errors generated.
[190/757] Building CXX object CMakeFiles/rocksdb.dir/table/block_based/block_based_table_reader.cc.o

Apr 24 '25 18:04 BwL1289

fix compilation error on apple-clang 15

Action Required

Process