rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

Disable `inplace_update_support` in crash test with unsynced data loss

Open cbi42 opened this issue 1 year ago • 1 comments

Summary: With unsynced data loss, we replay traces to recover expected state to DB's latest sequence number. With inplace_update_support, the largest sequence number of memtable may not reflect the latest update. This is because inplace updates in memtable do not update sequence number. So we disable inplace_update_support where traces need to be replayed.

cbi42 avatar May 17 '24 22:05 cbi42

@cbi42 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 17 '24 22:05 facebook-github-bot

@cbi42 merged this pull request in facebook/rocksdb@c4782bde41fa368de3b9c63570357c8063f6e88e.

facebook-github-bot avatar May 18 '24 23:05 facebook-github-bot