rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

Cleanup some useless codes and fix the potential codes issues in compaction_job

Open ZhangHuiGui opened this issue 10 months ago • 2 comments

Simple PR for clear codes when i read compaction_join.cc :)

  1. remove some useless headers
  2. fix some potential codes issues

ZhangHuiGui avatar Apr 19 '24 06:04 ZhangHuiGui

Hi @ZhangHuiGui!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Apr 19 '24 06:04 facebook-github-bot

@jowlyzhang What do you think of these simple changes in compation_join.cc?

ZhangHuiGui avatar Apr 29 '24 06:04 ZhangHuiGui