rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

add c-api to get default cf handle

Open 979357361 opened this issue 1 year ago • 1 comments

rocksdb_batched_multi_get_cf has performance improvement than normal multi_get, however it needs a cf_handle arg, so add a C-API to get and destroy the default cf_handle, as many user only use the default cf.

Fixes #12316

979357361 avatar Apr 06 '24 07:04 979357361

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Apr 09 '24 15:04 facebook-github-bot

@979357361 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar May 27 '24 13:05 facebook-github-bot

@979357361 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar May 27 '24 13:05 facebook-github-bot

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar May 27 '24 23:05 facebook-github-bot

@979357361 has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot avatar May 31 '24 12:05 facebook-github-bot

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jun 03 '24 04:06 facebook-github-bot

@ajkr merged this pull request in facebook/rocksdb@21a16f9e6410613498a4be219998049f95fbdd3f.

facebook-github-bot avatar Jun 03 '24 18:06 facebook-github-bot

LGTM, thanks!

Hi @ajkr, I noticed that v9.3.1 has released and I can't find the [c-api to get default cf handle], is there anything wrong? what can I do to make it works? thanks, have a nice day~

979357361 avatar Jul 02 '24 06:07 979357361

9.3 was the May release. This landed in June so will be in 9.4. 9.4 is nearly ready to be tagged.

ajkr avatar Jul 08 '24 21:07 ajkr