rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

Published 20 hours ago • verified publisher icon facebook

JNI Reader for Table Iterator

Open swamirishi opened this issue 10 months ago • 16 comments

Adding a Jni layer for table Iterator. Also changing the table iterator's interface preparse internal key so that SSTFileReaderIterator can be reused.

swamirishi avatar Apr 05 '24 00:04 swamirishi

@cbi42 @jowlyzhang Can you please review this? In ozone we depend on jni for rocksdb apis. I have just added JNI layer for the table_iterator written in your PR.

swamirishi avatar Apr 05 '24 00:04 swamirishi

@jowlyzhang Can you check this PR?

swamirishi avatar May 04 '24 07:05 swamirishi

@jowlyzhang Can you check this PR?

Thanks for making the changes. Since this PR now mostly have java changes, I'll leave it to @adamretter to make the call here.

jowlyzhang avatar May 06 '24 16:05 jowlyzhang

@adamretter Apologies for the late response and not following through addressing review comments on time. I have addressed all the review comments. Can you please take a look at it? I have added a Java test for the same as well and also added required util functions as well in portal.h. FYI these util functions can be used in other JNI classes as well.

swamirishi avatar May 24 '24 01:05 swamirishi

@adamretter can you please take a look at this?

swamirishi avatar May 29 '24 04:05 swamirishi

@adamretter @jowlyzhang Can you please take a look at this patch, whenever you find time?

swamirishi avatar Jun 08 '24 02:06 swamirishi

@adamretter I have addressed all the review comments. Can you please take a look at the patch again?

swamirishi avatar Jun 12 '24 13:06 swamirishi

@adamretter Can you take a look at this?

swamirishi avatar Jun 20 '24 20:06 swamirishi

@swamirishi Not all of my comments have been addressed.

adamretter avatar Jun 21 '24 08:06 adamretter

@swamirishi Not all of my comments have been addressed.

@adamretter Yeah sorry I missed one of the comments. I have changed the method name and set the parameters to final. Can you check if this is fine now?

swamirishi avatar Jun 22 '24 02:06 swamirishi

@adamretter can you please look into this I have addressed all the review comments here.

swamirishi avatar Jul 15 '24 15:07 swamirishi

@adamretter @jowlyzhang Can you please take a look at this patch? I have addressed all the review comments and this has been pending for a while.

swamirishi avatar Jul 24 '24 17:07 swamirishi

@swamirishi Apologies, I have been on holiday. I will try and review this shortly...

adamretter avatar Jul 31 '24 08:07 adamretter

@adamretter thanks a lot

swamirishi avatar Jul 31 '24 22:07 swamirishi

@adamretter Any updates on this?

swamirishi avatar Aug 31 '24 17:08 swamirishi

@adamretter Can you review this PR or is there anyone else who can review this PR if you are loaded with other stuff

swamirishi avatar Sep 17 '24 19:09 swamirishi