rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

Published 20 hours ago • verified publisher icon facebook

Limit re-opening WAL for truncating to current size

Open pdillinger opened this issue 11 months ago • 1 comments

Currently, we have code that calls ReopenWritableFile on the latest WAL file on recovery:

https://github.com/facebook/rocksdb/blob/9.0.fb/db/db_impl/db_impl_open.cc#L1555-L1566

with the purpose of freeing any fallocated space that might be leftover. This is unnecessary on filesystems that don't support fallocate, or maybe don't even support re-opening a file for write after it has been closed.

pdillinger avatar Mar 22 '24 23:03 pdillinger

but it looks like most major servers can be work. Is that right?

MalikHou avatar Jun 05 '24 09:06 MalikHou