facebook
Set optimize_filters_for_memory by default
Summary: ... when malloc_usable_size is known at compile time to be available. This feature has been around for a couple of years and users haven't reported any problems with it.
I've avoided using #ifdef in the public header to avoid a technical ODR violation, as it might be difficult for some users to ensure RocksDB and their code using RocksDB are built with the same macro definitions.
In avoiding that problem, I took the opportunity to fix another existing case with info_log_level.
Test Plan: unit tests updated, already in crash test. Some unit tests are expecting specific behaviors of optimize_filters_for_memory=false and we now need to bake that in.
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
Hmm, I have upset the Java gods by making the default value depend on a constant (derived from a preprocessor define)
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@pdillinger has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@pdillinger merged this pull request in facebook/rocksdb@45c105104bad2027edf6d2a668ffbace397e1f8a.