rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard
verified publisher icon facebook

IsEmpty() checks were missing before some SwitchMemtable() invocations

Open pranavshenoy opened this issue 1 year ago • 1 comments

Fixes #12179

There was one instance where the IsEmpty() check was missing: https://github.com/facebook/rocksdb/blob/21d5a8f54f06e01ca49d4e6bae89bb42ba78dfdd/db/db_impl/db_impl_write.cc#L1706

Having one check inside SwitchMemTable() will ensure there won't be misses in the future.

pranavshenoy avatar Jan 12 '24 03:01 pranavshenoy

This PR did not fix the issue, we applied this PR to our branch, the issue still exists: image

The gray text is empty MemTable.

rockeet avatar Jan 29 '24 02:01 rockeet