rocksdb

rocksdb copied to clipboard

Reame
Issues

Remove unused MSVC compiler warning supressions

Open rhubner opened this issue 1 year ago • 10 comments

Remove unused compiler warning supressions as was suggested in #10745.

Fixes #10745

Jan 04 '24 13:01 rhubner

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Jan 04 '24 20:01 facebook-github-bot

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Jan 04 '24 20:01 facebook-github-bot

@rhubner has updated the pull request. You must reimport the pull request before landing.

Jan 08 '24 14:01 facebook-github-bot

@rhubner has updated the pull request. You must reimport the pull request before landing.

Jan 08 '24 15:01 facebook-github-bot

@rhubner has updated the pull request. You must reimport the pull request before landing.

Jan 09 '24 07:01 facebook-github-bot

@rhubner has updated the pull request. You must reimport the pull request before landing.

Jan 09 '24 09:01 facebook-github-bot

@rhubner has updated the pull request. You must reimport the pull request before landing.

Jan 09 '24 13:01 facebook-github-bot

@rhubner has updated the pull request. You must reimport the pull request before landing.

Jan 12 '24 12:01 facebook-github-bot

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Jan 18 '24 18:01 facebook-github-bot

@rhubner has updated the pull request. You must reimport the pull request before landing.

Feb 07 '24 12:02 facebook-github-bot

@rhubner has updated the pull request. You must reimport the pull request before landing.

Mar 02 '24 10:03 facebook-github-bot

@rhubner has updated the pull request. You must reimport the pull request before landing.

Mar 03 '24 16:03 facebook-github-bot

@rhubner has updated the pull request. You must reimport the pull request before landing.

Mar 03 '24 16:03 facebook-github-bot

@rhubner has updated the pull request. You must reimport the pull request before landing.

Mar 03 '24 16:03 facebook-github-bot

@rhubner has updated the pull request. You must reimport the pull request before landing.

Mar 14 '24 08:03 facebook-github-bot

@pdillinger thanks for comments. I removed all the /4127 changes and left this PR as simple removal of three warnings. We can remove other warning supressin one-by-one later with individual PRs. I also borrowed some fixes from your PR Radek

Mar 14 '24 08:03 rhubner

@rhubner has updated the pull request. You must reimport the pull request before landing.

Mar 14 '24 08:03 facebook-github-bot

I also borrowed some fixes from your PR

FWIW, I want those fixes to be committed atomically with fixing the Windows CI. Then we can look at tightening the warnings.

Mar 14 '24 15:03 pdillinger

@rhubner has updated the pull request. You must reimport the pull request before landing.

Mar 15 '24 07:03 facebook-github-bot

@rhubner has updated the pull request. You must reimport the pull request before landing.

Mar 21 '24 16:03 facebook-github-bot

@ajkr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Mar 21 '24 19:03 facebook-github-bot

@ajkr merged this pull request in facebook/rocksdb@088dc7283bebb53eecdc21a0744931b3c88460f3.

Mar 21 '24 20:03 facebook-github-bot