rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

Cleanup and Fix JavaDoc issues in RocksJava

Open adamretter opened this issue 1 year ago • 1 comments

  • Fixed problems with existing JavaDoc.
  • Added missing JavaDoc.
  • Make JavaDoc warnings report as an error.
  • Add a CI job to ensure that JavaDoc is always present and correct in future.

In total this resolves over 400 JavaDoc warnings/errors.

adamretter avatar Dec 14 '23 21:12 adamretter

src/main/java/org/rocksdb/util/StdErrLogger.java:15: error: StdErrLogger is not abstract and does not override abstract method getNativeHandle() in LoggerInterface
public class StdErrLogger extends RocksObject implements LoggerInterface {
       ^
src/main/java/org/rocksdb/RocksDB.java:3945: warning: [deprecation] OUT_OF_BOUNDS in PerfLevel has been deprecated
    } else if (level == PerfLevel.OUT_OF_BOUNDS) {
                                 ^
1 error
1 warning

(https://github.com/facebook/rocksdb/actions/runs/7807589234/job/21296253965?pr=12149)

ajkr avatar Feb 20 '24 13:02 ajkr