facebook
Add sequence numbers Java tests
Add Java tests to check sequence numbers allocation with: flush and close, close without flush, and thread interrupts after flush.
Testing
- Locally ran Java tests:
...
Running: org.rocksdb.SecondaryDBTest
openAsSecondary OK
openAsSecondaryColumnFamilies OK
Tests run: 2, Failures: 0, Errors: 0, Ignored: 0, Time elapsed: 0.515 sec
Running: org.rocksdb.SequenceNumberAllocationTest
testSeqnoCloseWithoutFlush[true] OK
testSeqnoDataWrittenAfterFlush[true] OK
testSeqnoFlushAndClose[true] OK
testSeqnoThreadInterruptAfterFlush[true] OK
testSeqnoCloseWithoutFlush[false] OK
testSeqnoDataWrittenAfterFlush[false] OK
testSeqnoFlushAndClose[false] OK
testSeqnoThreadInterruptAfterFlush[false] OK
Tests run: 8, Failures: 0, Errors: 0, Ignored: 0, Time elapsed: 2.611 sec
Running: org.rocksdb.SliceTest
sliceRemovePrefix OK
slice OK
sliceToString OK
sliceClear OK
sliceStartWith OK
sliceEquals OK
Tests run: 6, Failures: 0, Errors: 0, Ignored: 0, Time elapsed: 0.003 sec
...
Hi @dnanuti!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
@dnanuti Do you still plan to complete this PR?
Yes, sorry, I had to switch the context. I will push the changes by EOW. Is there an .editorconfig that can be shared for the formatting issues? Or a make target that I can run?
Is there an .editorconfig that can be shared for the formatting issues? Or a make target that I can run?
I am afraid not.
@dnanuti I am afraid you still need to fix the code formatting issues, see the output from CI - https://github.com/facebook/rocksdb/actions/runs/6548421059/job/17802901391?pr=11563
@dnanuti I am afraid you still need to fix the code formatting issues, see the output from CI - https://github.com/facebook/rocksdb/actions/runs/6548421059/job/17802901391?pr=11563
run make format should handle this @dnanuti
@hx235 @dnanuti I added commits to fix the formatting, and also to add the tests to the CMake build. I think this should be good to land now.
@adamretter I switched projects and I totally missed your update. I rebased it on main. Thanks a lot for your support! @hx235 I haven't followed up with the discussions, I trust you know best if this should be merged or closed. Thank you both!