rocksdb
rocksdb copied to clipboard
facebook
Improves compaction output file cut to reduce WA
Try cut the file at grandparent files boundaries, which could be the beginning or the ending. Test shows it can improve WA more than 10%.
Also includes #1963 to cut file before skippable grandparent file. Which is for use case like user adding 2 or more non-overlapping data range at the same time, it can reduce the overlapping of 2 datasets in the lower levels.
@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
This change seems like it can have a big impact but the commit message content is too brief. Please include:
- a few more sentences about what was changed
- more detail on the perf test
- a description of whether or not this behavior depends on options. From the files I see there is a new option, that option should be explained in the commit message
@jay-zhuang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.