rocksdb icon indicating copy to clipboard operation
rocksdb copied to clipboard

No longer builds with NIOSTATS_CONTEXT

Open ronag opened this issue 1 year ago • 4 comments

../deps/rocksdb/rocksdb/logging/env_logger.h:60:7: error: use of undeclared identifier 'iostats_context'; did you mean 'get_iostats_context'?
      iostats_context.disable_iostats = true;
      ^~~~~~~~~~~~~~~
      get_iostats_context
../deps/rocksdb/rocksdb/include/rocksdb/iostats_context.h:95:17: note: 'get_iostats_context' declared here
IOStatsContext* get_iostats_context();
                ^
In file included from ../deps/rocksdb/rocksdb/env/env.cc:18:
../deps/rocksdb/rocksdb/logging/env_logger.h:60:22: error: member reference base type 'rocksdb::IOStatsContext *()' is not a structure or union
      iostats_context.disable_iostats = true;
      ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~
../deps/rocksdb/rocksdb/logging/env_logger.h:65:7: error: use of undeclared identifier 'iostats_context'; did you mean 'get_iostats_context'?
      iostats_context.disable_iostats = false;
      ^~~~~~~~~~~~~~~
      get_iostats_context
../deps/rocksdb/rocksdb/include/rocksdb/iostats_context.h:95:17: note: 'get_iostats_context' declared here
IOStatsContext* get_iostats_context();
                ^
In file included from ../deps/rocksdb/rocksdb/env/env.cc:18:
../deps/rocksdb/rocksdb/logging/env_logger.h:65:22: error: member reference base type 'rocksdb::IOStatsContext *()' is not a structure or union
      iostats_context.disable_iostats = false;

ronag avatar Aug 04 '22 07:08 ronag

Seems to be caused by cc2099803a1de4dab8aa748cb26b2650e740d197

ronag avatar Aug 04 '22 07:08 ronag

@siying

ronag avatar Aug 07 '22 05:08 ronag

@ajkr Please help to review: #10506 :)

lhsoft avatar Aug 09 '22 15:08 lhsoft

Thanks for pointing it out, will fix.

siying avatar Aug 09 '22 19:08 siying