facebook
Enable checking Typescript files behind a compiler flag
Fix for #4745
Behind a compiler flag, typescript_check_generated_files, removes the @ts-nocheck flag from being output within typescript generated files by the Relay Compiler.
This is not safe to enable yet, but will allow for identifying Typescript issues in the generated code by enabling this flag to find those issues.
Notes:
- Added a new compiler flag (not a feature flag, can change to be a feature flag if that is more appropriate)
- Updated Tests
Hi @drewatk!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Hey @captbaritone, let me know what you think about this approach and if there are any blockers to merging this. I've updated it to the latest code and checks are passing
Yikes. Sorry we lost track of this. Do you mind rebasing? I can merge.
