redex icon indicating copy to clipboard operation
redex copied to clipboard

A bunch of small changes in cmake.

Open igor-eremeev opened this issue 7 years ago • 4 comments

  1. Whole-archive was broken for gcc, it requires a closing block after the library.
  2. Pthread library was missing, linking was failing. Add it to cmake. I hope that cmake version bumping is ok. Please check windows cmake compilation after this, I don't have one to do it myself.
  3. Implement the simplest possible packaging task for redex-all into redex bundle.

igor-eremeev avatar Dec 29 '17 10:12 igor-eremeev

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 29 '17 10:12 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot avatar Dec 29 '17 10:12 facebook-github-bot

@igor-eremeev Thanks for the suggestions!

  1. Thanks. I will test and incorporate your change.
  2. I will remove pthread instead (we'd like to minimize dependencies). Any reason why you want to bump CMake version?
  3. I was considering CPack for installation. Your approach seems interesting. I will consider it.

minjang avatar Jan 02 '18 17:01 minjang

Thanks for reply!

Any reason why you want to bump CMake version?

No, it was only for simplicity of adding pthreads via this new shiny "Threads::Threads" thing, which is 3.1.0+. If pthreads are not an issue anymore, then just discard this :)

igor-eremeev avatar Jan 09 '18 08:01 igor-eremeev