facebook
[Speculative fix] Fix ViewTransition crash in Mobile Safari
Speculative fix to https://github.com/facebook/react/issues/35336 written by Claude.
I have verified that applying a similar patch locally to the repro from #35336 does fix the crash.
I'm not familiar enough with the underlying APIs to tell whether the fix is correct or sufficient.
Comparing: 55480b4d228986e502f4651f8e53a6f264a1858e...95d73311ee07c1485ec5d3d8e3e0d00e3a46fcb4
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.js | = | 6.84 kB | 6.84 kB | = | 1.88 kB | 1.88 kB |
| oss-stable/react-dom/cjs/react-dom-client.production.js | = | 608.36 kB | 608.16 kB | = | 107.68 kB | 107.67 kB |
| oss-experimental/react-dom/cjs/react-dom.production.js | = | 6.84 kB | 6.84 kB | = | 1.88 kB | 1.88 kB |
| oss-experimental/react-dom/cjs/react-dom-client.production.js | = | 667.47 kB | 667.39 kB | = | 117.57 kB | 117.55 kB |
| facebook-www/ReactDOM-prod.classic.js | = | 693.67 kB | 693.47 kB | = | 122.07 kB | 122.05 kB |
| facebook-www/ReactDOM-prod.modern.js | = | 684.10 kB | 683.89 kB | = | 120.45 kB | 120.43 kB |
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)
Generated by :no_entry_sign: dangerJS against 95d73311ee07c1485ec5d3d8e3e0d00e3a46fcb4
Not sure if it fixes it in all cases though if the staleness also happens to apply to any of these.
Yea not sure, I guess let's try it and see if I can hit it again at some other codepath