react icon indicating copy to clipboard operation
react copied to clipboard

[Fizz] Push a stalled use() to the ownerStack/debugTask

Open eps1lon opened this issue 3 months ago • 1 comments

Same as https://github.com/facebook/react/issues/33634 but for use and promise-as-a-child.

An alternative to re-rendering would've been to eagerly collect use() calls but we know Error() is slow in v8.

The danger with lazily collecting use() is that the Thenable may be resolved when we abort. In those cases we remove instrumentation on the last thenable to ensure we suspend again. To ensure Thenable subclasses can't observe the corrupted state, we noop .then.

The shown stack relies on sourcemaps with ignoreList. Otherwise it'll point into React internals. From the dispatcher we wouldn't know how many stacks we have to cut without a circular dependency to the React.use function.

eps1lon avatar Nov 26 '25 14:11 eps1lon

Comparing: bf1afade8d95d2ef6e862d995ee74921ca8d47c7...3c7b53f49f89cc30ad35c311e7ee665d535104aa

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.16% 1.88 kB 1.88 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 608.36 kB 608.36 kB = 107.68 kB 107.68 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.84 kB 6.84 kB +0.16% 1.88 kB 1.88 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 667.47 kB 667.47 kB = 117.57 kB 117.57 kB
facebook-www/ReactDOM-prod.classic.js = 693.67 kB 693.67 kB = 122.06 kB 122.07 kB
facebook-www/ReactDOM-prod.modern.js = 684.10 kB 684.10 kB = 120.44 kB 120.45 kB
oss-stable-semver/react-server/cjs/react-server.development.js +2.12% 205.20 kB 209.55 kB +2.24% 36.17 kB 36.98 kB
oss-stable/react-server/cjs/react-server.development.js +2.12% 205.20 kB 209.55 kB +2.24% 36.17 kB 36.98 kB
oss-experimental/react-server/cjs/react-server.development.js +2.07% 209.99 kB 214.34 kB +2.17% 37.10 kB 37.90 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable-semver/react-server/cjs/react-server.development.js +2.12% 205.20 kB 209.55 kB +2.24% 36.17 kB 36.98 kB
oss-stable/react-server/cjs/react-server.development.js +2.12% 205.20 kB 209.55 kB +2.24% 36.17 kB 36.98 kB
oss-experimental/react-server/cjs/react-server.development.js +2.07% 209.99 kB 214.34 kB +2.17% 37.10 kB 37.90 kB
oss-experimental/react-markup/cjs/react-markup.development.js +1.08% 391.32 kB 395.55 kB +1.06% 71.12 kB 71.88 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.node.development.js +1.08% 404.15 kB 408.50 kB +1.14% 73.12 kB 73.95 kB
oss-stable-semver/react-dom/cjs/react-dom-server-legacy.browser.development.js +1.08% 404.15 kB 408.50 kB +1.14% 73.12 kB 73.95 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.node.development.js +1.08% 404.17 kB 408.52 kB +1.14% 73.14 kB 73.98 kB
oss-stable/react-dom/cjs/react-dom-server-legacy.browser.development.js +1.08% 404.18 kB 408.52 kB +1.14% 73.14 kB 73.98 kB
facebook-www/ReactDOMServerStreaming-dev.modern.js +1.05% 413.56 kB 417.91 kB +1.09% 74.09 kB 74.90 kB
facebook-www/ReactDOMServer-dev.modern.js +1.05% 415.05 kB 419.40 kB +1.13% 74.50 kB 75.34 kB
facebook-www/ReactDOMServer-dev.classic.js +1.04% 418.49 kB 422.84 kB +1.13% 75.09 kB 75.94 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js +1.04% 419.47 kB 423.81 kB +1.10% 75.36 kB 76.19 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js +1.04% 419.47 kB 423.82 kB +1.10% 75.36 kB 76.19 kB
oss-stable-semver/react-dom/cjs/react-dom-server.bun.development.js +1.03% 383.97 kB 387.91 kB +1.11% 72.83 kB 73.63 kB
oss-stable/react-dom/cjs/react-dom-server.bun.development.js +1.03% 384.05 kB 387.99 kB +1.11% 72.85 kB 73.66 kB
oss-stable-semver/react-dom/cjs/react-dom-server.browser.development.js +1.00% 433.50 kB 437.84 kB +1.11% 77.24 kB 78.10 kB
oss-stable/react-dom/cjs/react-dom-server.browser.development.js +1.00% 433.57 kB 437.92 kB +1.12% 77.29 kB 78.15 kB
oss-stable-semver/react-dom/cjs/react-dom-server.edge.development.js +1.00% 434.28 kB 438.62 kB +1.13% 77.41 kB 78.28 kB
oss-stable/react-dom/cjs/react-dom-server.edge.development.js +1.00% 434.35 kB 438.70 kB +1.13% 77.46 kB 78.33 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js +0.99% 398.20 kB 402.14 kB +1.11% 75.14 kB 75.98 kB
oss-stable-semver/react-dom/cjs/react-dom-server.node.development.js +0.99% 440.53 kB 444.88 kB +1.15% 77.20 kB 78.09 kB
oss-stable/react-dom/cjs/react-dom-server.node.development.js +0.99% 440.61 kB 444.96 kB +1.15% 77.25 kB 78.14 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js +0.97% 449.86 kB 454.20 kB +1.09% 79.54 kB 80.42 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js +0.96% 450.86 kB 455.21 kB +1.09% 79.77 kB 80.64 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js +0.95% 456.62 kB 460.97 kB +1.08% 79.53 kB 80.40 kB
oss-experimental/react-markup/cjs/react-markup.react-server.development.js +0.64% 667.16 kB 671.41 kB +0.68% 118.28 kB 119.08 kB

Generated by :no_entry_sign: dangerJS against 3c7b53f49f89cc30ad35c311e7ee665d535104aa

react-sizebot avatar Dec 02 '25 17:12 react-sizebot