react icon indicating copy to clipboard operation
react copied to clipboard

Backport `useId` tracking fix to React 18

Open kognise opened this issue 1 year ago • 3 comments

Fixes #31653.

A hydration error occurs when using useId with a parent that has a render phase update. @gnoff and @sebmarkbage fixed this for React 19 in #25713.

React 18 will have users for some time, and we are encountering this issue in production. For these reasons, I think it is a good idea to backport that fix to React 18.

I am definitely not a React contributor nor familiar with its internals, so this may be unwanted or an incorrect solution. I also apologize if I used the wrong base branch for a new release.

Consideration appreciated!

kognise avatar Dec 04 '24 00:12 kognise

@kognise is attempting to deploy a commit to the Meta Open Source Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Dec 04 '24 00:12 vercel[bot]

Hi @kognise!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

facebook-github-bot avatar Dec 04 '24 00:12 facebook-github-bot

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot avatar Dec 04 '24 02:12 facebook-github-bot

Is there any chance for merge for next patch release in react@18? Seems like formality - since the same solution is already merged for react@19 ?

sculpt0r avatar Jan 03 '25 12:01 sculpt0r

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Jun 07 '25 13:06 github-actions[bot]

Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!

github-actions[bot] avatar Jun 14 '25 14:06 github-actions[bot]