facebook
Upgrade devtools dependency update-notifier to 5.x
Summary
This PR upgrades the dependency on update-notifier, used in react-devtools, to 5.x This is the latest non-ESM version, so upgrading to it should be unproblematic (while updating to 6.x and beyond will have to wait).
Upgrading means we avoid installing a lot of outdated dependencies (as can be seen from the diff in yarn.lock), and resolves part of https://github.com/facebook/react/issues/28058
Changelog: https://github.com/yeoman/update-notifier/releases
The most relevant breaking change seems to be that the minimum support node version is increased from v6 to v10, but I couldn't find what is currently React's official node version support.
How did you test this change?
I ran the test-suite locally (yarn test in root folder), but I'm not sure if that one actually covers devtools?
I also built and tested this version of devtools with some internal company projects (both react and react-native based) – following guidelines from https://github.com/facebook/react/issues/28058#issuecomment-1943619292.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-compiler-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Dec 2, 2024 10:16pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Thanks! For security reasons, someone on the team should update the lockfile manually before merging this. The changes are too big for me to review manually.
cc @hoxyq @eps1lon
Comparing: dd048c3b2d8b5760dec718fb0926ca0b68660922...c9ea15d946af80c49f1d97f84f282a943dadaaf4
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.js | = | 6.68 kB | 6.68 kB | = | 1.83 kB | 1.83 kB |
| oss-stable/react-dom/cjs/react-dom-client.production.js | = | 607.89 kB | 607.89 kB | = | 107.61 kB | 107.61 kB |
| oss-experimental/react-dom/cjs/react-dom.production.js | = | 6.69 kB | 6.69 kB | = | 1.83 kB | 1.83 kB |
| oss-experimental/react-dom/cjs/react-dom-client.production.js | = | 665.84 kB | 665.84 kB | = | 117.34 kB | 117.34 kB |
| facebook-www/ReactDOM-prod.classic.js | = | 691.67 kB | 691.67 kB | = | 121.70 kB | 121.70 kB |
| facebook-www/ReactDOM-prod.modern.js | = | 682.09 kB | 682.09 kB | = | 120.08 kB | 120.08 kB |
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)
Generated by :no_entry_sign: dangerJS against c9ea15d946af80c49f1d97f84f282a943dadaaf4
