facebook
fix: null detail error for native events
Summary
Our application throws errors in production, and we've located the problem at the same source as issue #24989. This PR avoids null values for nativeEvent.detail, preventing the error.
How did you test this change?
I don't see an easy way to test the change and couldn't set up unit tests for the react-dom-bindings package. Any help on this matter would be much appreciated.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-compiler-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 29, 2024 3:17pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
@gaearon @trueadm, I see that you were the last ones to work on this code. I would appreciate your review to ensure this change doesn't break anything. 🙇
@gnoff @mofeiZ @josephsavona just pinging because you are active maintainers. Could you provide some advice on how to get this PR reviewed and merged? Thanks in advance.
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!