react icon indicating copy to clipboard operation
react copied to clipboard

Disable enablePostpone flag in experimental

Open sebmarkbage opened this issue 1 year ago • 2 comments

I don't think we're ready to land this yet since we're using it to run other experiments and our tests. I'm opening this PR to indicate intent to disable and to ensure tests in other combinations still work. Such as enableHalt without enablePostpone. I think we'll also need to rewrite some tests that depend on enablePostpone to preserve some coverage.

The conclusion after this experiment is that try/catch around these are too likely to block these signals and consider them error. Throwing works for Hooks and use() because the lint rule can ensure that they're not wrapped in try/catch. Throwing in arbitrary functions not quite ecosystem compatible. It's also why there's use() and not just throwing a Promise. This might also affect the Catch proposal.

The "prerender" for SSR that's supporting "Partial Prerendering" is still there. This just disables the React.postpone() API for creating the holes.

sebmarkbage avatar Sep 24 '24 06:09 sebmarkbage

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 6:28am

vercel[bot] avatar Sep 24 '24 06:09 vercel[bot]

Comparing: 986323f8c65927490036183357d644974a14b8a3...0c92ae0b62d9b65ec0d5290640748fa7d2b0dbb9

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 607.89 kB 607.89 kB = 107.61 kB 107.61 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 666.84 kB 665.84 kB = 117.49 kB 117.34 kB
facebook-www/ReactDOM-prod.classic.js = 691.67 kB 691.67 kB = 121.70 kB 121.70 kB
facebook-www/ReactDOM-prod.modern.js = 682.09 kB 682.09 kB = 120.08 kB 120.08 kB
oss-experimental/react-markup/cjs/react-markup.react-server.production.js = 363.57 kB 356.02 kB = 67.12 kB 66.11 kB
oss-experimental/react-markup/cjs/react-markup.production.js = 252.29 kB 246.92 kB = 46.31 kB 45.66 kB
oss-experimental/react-server/cjs/react-server-flight.production.js = 69.32 kB 67.69 kB = 13.62 kB 13.41 kB
oss-experimental/react-server/cjs/react-server.development.js = 217.04 kB 209.58 kB = 37.58 kB 36.98 kB
oss-experimental/react-server/cjs/react-server.production.js = 154.56 kB 148.91 kB = 26.82 kB 26.19 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-reconciler/cjs/react-reconciler.production.js = 487.35 kB 486.26 kB = 77.51 kB 77.35 kB
oss-experimental/react-art/cjs/react-art.production.js = 356.51 kB 355.70 kB = 60.12 kB 59.95 kB
oss-experimental/react/cjs/react.development.js = 51.34 kB 51.12 kB = 11.56 kB 11.50 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.development.js = 190.85 kB 189.97 kB = 33.39 kB 33.24 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.development.js = 190.83 kB 189.95 kB = 33.38 kB 33.23 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.development.js = 189.42 kB 188.54 kB = 33.13 kB 32.98 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.development.js = 187.71 kB 186.84 kB = 32.85 kB 32.70 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.development.js = 186.13 kB 185.26 kB = 32.78 kB 32.65 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.development.js = 185.89 kB 185.01 kB = 32.75 kB 32.60 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.development.js = 185.51 kB 184.64 kB = 32.62 kB 32.48 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.development.js = 182.93 kB 182.06 kB = 32.15 kB 32.01 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.development.js = 180.97 kB 180.10 kB = 31.72 kB 31.57 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.development.js = 184.79 kB 183.89 kB = 32.63 kB 32.49 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.development.js = 184.77 kB 183.86 kB = 32.62 kB 32.47 kB
oss-experimental/react-client/cjs/react-client-flight.development.js = 176.29 kB 175.42 kB = 30.66 kB 30.51 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.development.js = 181.56 kB 180.66 kB = 32.12 kB 31.97 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.development.js = 227.43 kB 226.28 kB = 50.17 kB 49.98 kB
oss-experimental/react/cjs/react.react-server.development.js = 39.21 kB 39.00 kB = 9.18 kB 9.13 kB
oss-experimental/react-server-dom-esm/esm/react-server-dom-esm-client.browser.production.js = 96.00 kB 95.21 kB = 19.62 kB 19.51 kB
oss-experimental/react-client/cjs/react-client-flight.production.js = 67.13 kB 66.57 kB = 12.12 kB 12.02 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.production.js = 72.04 kB 71.40 kB = 14.06 kB 13.93 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.node.production.js = 72.01 kB 71.38 kB = 14.05 kB 13.91 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.edge.production.js = 67.44 kB 66.84 kB = 13.38 kB 13.26 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.edge.production.js = 67.42 kB 66.81 kB = 13.37 kB 13.25 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.node.unbundled.production.js = 70.86 kB 70.22 kB = 13.81 kB 13.68 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.node.production.js = 68.74 kB 68.10 kB = 13.40 kB 13.27 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.edge.production.js = 64.34 kB 63.74 kB = 12.76 kB 12.65 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.node.production.js = 67.57 kB 66.94 kB = 13.12 kB 13.01 kB
oss-experimental/react/cjs/react.production.js = 19.27 kB 19.09 kB = 4.90 kB 4.85 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-client.browser.production.js = 61.45 kB 60.85 kB = 12.12 kB 11.99 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-client.browser.production.js = 61.08 kB 60.48 kB = 12.04 kB 11.91 kB
oss-experimental/react/cjs/react.react-server.production.js = 18.92 kB 18.74 kB = 4.98 kB 4.93 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-client.browser.production.js = 59.11 kB 58.51 kB = 11.63 kB 11.51 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-client.browser.production.js = 58.82 kB 58.21 kB = 11.56 kB 11.44 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.development.js = 231.43 kB 228.91 kB = 41.63 kB 41.25 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.development.js = 231.38 kB 228.86 kB = 41.63 kB 41.26 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.development.js = 230.18 kB 227.66 kB = 41.33 kB 40.96 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.development.js = 223.47 kB 220.95 kB = 40.26 kB 39.88 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.development.js = 216.95 kB 214.43 kB = 39.57 kB 39.21 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.development.js = 199.71 kB 197.32 kB = 36.20 kB 35.83 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.development.js = 199.24 kB 196.84 kB = 36.10 kB 35.73 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.development.js = 191.39 kB 189.00 kB = 34.74 kB 34.38 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.node.production.js = 112.43 kB 110.99 kB = 22.45 kB 22.26 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.production.js = 112.42 kB 110.98 kB = 22.45 kB 22.26 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.node.unbundled.production.js = 111.36 kB 109.92 kB = 22.23 kB 21.96 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.development.js = 203.28 kB 200.54 kB = 36.63 kB 36.21 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.development.js = 203.28 kB 200.54 kB = 36.63 kB 36.21 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.node.production.js = 105.29 kB 103.85 kB = 21.20 kB 21.02 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.browser.production.js = 105.20 kB 103.73 kB = 21.22 kB 21.04 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.development.js = 195.40 kB 192.65 kB = 35.29 kB 34.88 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.browser.production.js = 104.85 kB 103.37 kB = 21.12 kB 20.95 kB
oss-experimental/react-server-dom-esm/cjs/react-server-dom-esm-server.node.production.js = 101.37 kB 99.93 kB = 20.73 kB 20.49 kB
oss-experimental/react-server-dom-turbopack/cjs/react-server-dom-turbopack-server.edge.production.js = 106.09 kB 104.53 kB = 21.43 kB 21.24 kB
oss-experimental/react-server-dom-webpack/cjs/react-server-dom-webpack-server.edge.production.js = 106.09 kB 104.53 kB = 21.43 kB 21.24 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.browser.production.js = 97.79 kB 96.31 kB = 19.94 kB 19.74 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.development.js = 404.71 kB 398.37 kB = 75.64 kB 75.01 kB
oss-experimental/react-server-dom-parcel/cjs/react-server-dom-parcel-server.edge.production.js = 99.01 kB 97.45 kB = 20.20 kB 20.00 kB
oss-experimental/react-markup/cjs/react-markup.react-server.development.js = 676.87 kB 666.04 kB = 119.20 kB 118.00 kB
oss-experimental/react-dom/cjs/react-dom-server.node.development.js = 464.11 kB 456.64 kB = 80.12 kB 79.39 kB
oss-experimental/react-server/cjs/react-server-flight.development.js = 147.64 kB 145.25 kB = 26.37 kB 25.98 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.development.js = 458.16 kB 450.69 kB = 80.36 kB 79.61 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.development.js = 457.15 kB 449.68 kB = 80.11 kB 79.38 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.development.js = 426.14 kB 418.68 kB = 75.92 kB 75.16 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.development.js = 426.14 kB 418.68 kB = 75.92 kB 75.16 kB
oss-experimental/react-dom/cjs/react-dom-server.node.production.js = 308.76 kB 303.30 kB = 53.79 kB 53.15 kB
oss-experimental/react-dom/cjs/react-dom-server.edge.production.js = 300.91 kB 295.45 kB = 53.95 kB 53.29 kB
oss-experimental/react-dom/cjs/react-dom-server.browser.production.js = 294.57 kB 289.22 kB = 51.58 kB 50.97 kB
oss-experimental/react-dom/cjs/react-dom-server.bun.production.js = 295.50 kB 290.02 kB = 51.40 kB 50.74 kB
oss-experimental/react-markup/cjs/react-markup.development.js = 398.22 kB 390.80 kB = 71.66 kB 70.94 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.node.production.js = 270.45 kB 265.06 kB = 49.15 kB 48.52 kB
oss-experimental/react-dom/cjs/react-dom-server-legacy.browser.production.js = 264.91 kB 259.63 kB = 47.02 kB 46.42 kB
oss-experimental/react-markup/cjs/react-markup.react-server.production.js = 363.57 kB 356.02 kB = 67.12 kB 66.11 kB
oss-experimental/react-markup/cjs/react-markup.production.js = 252.29 kB 246.92 kB = 46.31 kB 45.66 kB
oss-experimental/react-server/cjs/react-server-flight.production.js = 69.32 kB 67.69 kB = 13.62 kB 13.41 kB
oss-experimental/react-server/cjs/react-server.development.js = 217.04 kB 209.58 kB = 37.58 kB 36.98 kB
oss-experimental/react-server/cjs/react-server.production.js = 154.56 kB 148.91 kB = 26.82 kB 26.19 kB

Generated by :no_entry_sign: dangerJS against 0c92ae0b62d9b65ec0d5290640748fa7d2b0dbb9

react-sizebot avatar Sep 24 '24 06:09 react-sizebot