facebook
Fix:-Fixed Error not thrown on passing invalid Args in hydrateRoot call
fixes #30876
ThIS PR fixes the invalid argument validation error, where it does not throw the valid error it should throw for the options argument, tests have been added as required
cc @hoxyq @sebmarkbage
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-compiler-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Sep 4, 2024 3:22pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Comparing: d1afcb43fd506297109c32ff462f6f659f9110ae...5e0654c0810facbf261e79ddd6e120e79278cfd3
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.js | = | 6.68 kB | 6.68 kB | +0.05% | 1.82 kB | 1.82 kB |
| oss-stable/react-dom/cjs/react-dom-client.production.js | = | 501.40 kB | 501.40 kB | = | 89.99 kB | 89.99 kB |
| oss-experimental/react-dom/cjs/react-dom.production.js | = | 6.69 kB | 6.69 kB | +0.11% | 1.83 kB | 1.83 kB |
| oss-experimental/react-dom/cjs/react-dom-client.production.js | = | 508.52 kB | 508.52 kB | = | 91.16 kB | 91.16 kB |
| facebook-www/ReactDOM-prod.classic.js | = | 596.16 kB | 596.16 kB | = | 105.69 kB | 105.70 kB |
| facebook-www/ReactDOM-prod.modern.js | = | 572.44 kB | 572.44 kB | = | 101.88 kB | 101.88 kB |
Significant size changes
Includes any change greater than 0.2%:
Expand to show
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| test_utils/ReactAllWarnings.js | +0.54% | 64.07 kB | 64.41 kB | +0.38% | 15.86 kB | 15.92 kB |
Generated by :no_entry_sign: dangerJS against a76ac7ef05335d4152235f81ffd46e5854ddaad1
@sebmarkbage i am not sure why ReactDOMServerIntegrationBasic-test.js is failing, ? is it related to my changes if yes how
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!