react icon indicating copy to clipboard operation
react copied to clipboard

[DoNotCommit] Turn on enableFabricCompleteRootInCommitPhase for OSS

Open cipolleschi opened this issue 1 year ago • 2 comments

Summary

In OSS and in React Native, startTransition is behaving oddly, not yielding properly. We believe the the enableFabricCompleteRootInCommitPhase flag might fix this behavior.

This PR turns on the flag only for OSS to let CI build the artifacts we need to test this hypothesis

How did you test this change?

CI

cipolleschi avatar Sep 02 '24 16:09 cipolleschi

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 2, 2024 4:33pm

vercel[bot] avatar Sep 02 '24 16:09 vercel[bot]

Comparing: 4f604941569d2e8947ce1460a0b2997e835f37b9...6f82da8a3d2f65002f07e2af79802a05c7d36a94

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.40 kB 501.40 kB = 89.99 kB 89.99 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 508.52 kB 508.52 kB = 91.16 kB 91.16 kB
facebook-www/ReactDOM-prod.classic.js = 596.16 kB 596.16 kB = 105.70 kB 105.69 kB
facebook-www/ReactDOM-prod.modern.js = 572.44 kB 572.44 kB = 101.88 kB 101.88 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by :no_entry_sign: dangerJS against 0b2ccdd7351d61c6f31074c85f2bd94e69be9076

react-sizebot avatar Sep 02 '24 16:09 react-sizebot

This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.

github-actions[bot] avatar Dec 01 '24 17:12 github-actions[bot]