react icon indicating copy to clipboard operation
react copied to clipboard

[uMC] Also reset cache on size changes

Open poteto opened this issue 1 year ago • 3 comments

Stack from ghstack (oldest at bottom):

  • -> #30829

There may still be rare instances in dev where the cache size changes between renders, so just reset the cache since it's safe to do so anyway.

poteto avatar Aug 27 '24 21:08 poteto

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 27, 2024 9:39pm

vercel[bot] avatar Aug 27 '24 21:08 vercel[bot]

Comparing: 7771d3a7972cc2483c45fde51b7ec2d926cba097...34282691df69544b0fdc22b3ce6ed18a510d3b3d

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB +0.05% 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 501.40 kB 501.43 kB +0.01% 89.99 kB 90.00 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB +0.05% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 508.52 kB 508.55 kB = 91.16 kB 91.17 kB
facebook-www/ReactDOM-prod.classic.js = 596.16 kB 596.19 kB = 105.70 kB 105.71 kB
facebook-www/ReactDOM-prod.modern.js = 572.44 kB 572.47 kB +0.01% 101.88 kB 101.89 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js = 64.07 kB 63.92 kB = 15.86 kB 15.81 kB

Generated by :no_entry_sign: dangerJS against 18fdcbd9f234e5e1f9c686aa22ebfe889745eeb0

react-sizebot avatar Aug 27 '24 21:08 react-sizebot

Hmmm do we know why this happens exactly? Because it could indicate a bug, where a hook is being rendered conditionally. Suppressing the size change could make it harder to find that bug.

josephsavona avatar Aug 28 '24 02:08 josephsavona