react icon indicating copy to clipboard operation
react copied to clipboard
Published 3 months ago • verified publisher icon facebook

Build `react-dom` in `builds/facebook-fbsource`

Open yungsters opened this issue 1 year ago • 4 comments

Summary

Builds react-dom for React Native so that it also populates the builds/facebook-fbsource branch.

NOTE: For Meta employees, D61354219 is the internal integration.

How did you test this change?

$ yarn build
…
$ ls build/facebook-react-native/react-dom/cjs
ReactDOM-dev.js       ReactDOM-prod.js      ReactDOM-profiling.js

yungsters avatar Aug 15 '24 15:08 yungsters

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 18, 2024 8:27pm

vercel[bot] avatar Aug 15 '24 15:08 vercel[bot]

Comparing: 09d82835993b16cd5dc8350c03627f9573354a25...d5f26fb12e204c98f259062e629ca24bd139f897

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 508.22 kB 508.22 kB = 90.95 kB 90.95 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 513.15 kB 513.15 kB = 91.67 kB 91.67 kB
facebook-www/ReactDOM-prod.classic.js = 602.57 kB 602.57 kB = 106.64 kB 106.64 kB
facebook-www/ReactDOM-prod.modern.js = 578.84 kB 578.84 kB = 102.76 kB 102.76 kB
facebook-react-native/react-dom/cjs/ReactDOM-dev.js +∞% 0.00 kB 17.15 kB +∞% 0.00 kB 3.78 kB
facebook-react-native/react-dom/cjs/ReactDOM-prod.js +∞% 0.00 kB 6.48 kB +∞% 0.00 kB 1.81 kB
facebook-react-native/react-dom/cjs/ReactDOM-profiling.js +∞% 0.00 kB 6.48 kB +∞% 0.00 kB 1.81 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js +∞% 0.00 kB 974.86 kB +∞% 0.00 kB 164.39 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-prod.js +∞% 0.00 kB 533.29 kB +∞% 0.00 kB 94.87 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js +∞% 0.00 kB 558.22 kB +∞% 0.00 kB 98.62 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js +∞% 0.00 kB 991.20 kB +∞% 0.00 kB 167.21 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-prod.js +∞% 0.00 kB 538.79 kB +∞% 0.00 kB 95.95 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js +∞% 0.00 kB 564.16 kB +∞% 0.00 kB 99.77 kB
facebook-react-native/react-dom/cjs/ReactDOMTestUtils-dev.js +∞% 0.00 kB 1.39 kB +∞% 0.00 kB 0.71 kB
facebook-react-native/react-dom/cjs/ReactDOMTestUtils-prod.js +∞% 0.00 kB 0.67 kB +∞% 0.00 kB 0.41 kB
facebook-react-native/react-dom/cjs/ReactDOMTestUtils-profiling.js +∞% 0.00 kB 0.67 kB +∞% 0.00 kB 0.41 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-react-native/react-dom/cjs/ReactDOM-dev.js +∞% 0.00 kB 17.15 kB +∞% 0.00 kB 3.78 kB
facebook-react-native/react-dom/cjs/ReactDOM-prod.js +∞% 0.00 kB 6.48 kB +∞% 0.00 kB 1.81 kB
facebook-react-native/react-dom/cjs/ReactDOM-profiling.js +∞% 0.00 kB 6.48 kB +∞% 0.00 kB 1.81 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-dev.js +∞% 0.00 kB 974.86 kB +∞% 0.00 kB 164.39 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-prod.js +∞% 0.00 kB 533.29 kB +∞% 0.00 kB 94.87 kB
facebook-react-native/react-dom/cjs/ReactDOMClient-profiling.js +∞% 0.00 kB 558.22 kB +∞% 0.00 kB 98.62 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-dev.js +∞% 0.00 kB 991.20 kB +∞% 0.00 kB 167.21 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-prod.js +∞% 0.00 kB 538.79 kB +∞% 0.00 kB 95.95 kB
facebook-react-native/react-dom/cjs/ReactDOMProfiling-profiling.js +∞% 0.00 kB 564.16 kB +∞% 0.00 kB 99.77 kB
facebook-react-native/react-dom/cjs/ReactDOMTestUtils-dev.js +∞% 0.00 kB 1.39 kB +∞% 0.00 kB 0.71 kB
facebook-react-native/react-dom/cjs/ReactDOMTestUtils-prod.js +∞% 0.00 kB 0.67 kB +∞% 0.00 kB 0.41 kB
facebook-react-native/react-dom/cjs/ReactDOMTestUtils-profiling.js +∞% 0.00 kB 0.67 kB +∞% 0.00 kB 0.41 kB

Generated by :no_entry_sign: dangerJS against 2531d132fdf45e4ae2e57f7eba28cb76952bd659

react-sizebot avatar Aug 15 '24 15:08 react-sizebot

Hmm… actually, ReactDOMFB.js is pretty specific to www (e.g. ReactFiberErrorDialogWWW).

I'm going to switch this to build the non-FB react-dom for facebook-react-native.

yungsters avatar Aug 15 '24 20:08 yungsters

Let me rebase this.

yungsters avatar Aug 19 '24 23:08 yungsters