Feat:- Added no import expression eslint rule
While using Dynamic Imports, having hit by certain type of imports like below
// Example 1: String literal
const modulePath = "import('./dynamicModule.js')";
// Example 2: Template literal
const getModule = `import(${'./dynamicModule.js'})`;
// Example 3: String literal in an object
const config = {
loader: "import('./loader.js')"
};
when imports appear inside a literal, a rule shall be implemented to avoid such imports.
I have added test further for the rule
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-compiler-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Aug 1, 2024 11:09am |
@eps1lon would love to know your thoughts on this one.
Comparing: 88ee14ffa57beb0689f26f0c52c357e3ac446af8...700fe8c8f54507d40d8f8127f3df21e0287f3457
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.js | = | 6.68 kB | 6.68 kB | +0.05% | 1.82 kB | 1.82 kB |
| oss-stable/react-dom/cjs/react-dom-client.production.js | = | 500.37 kB | 500.37 kB | = | 89.80 kB | 89.80 kB |
| oss-experimental/react-dom/cjs/react-dom.production.js | = | 6.69 kB | 6.69 kB | +0.05% | 1.83 kB | 1.83 kB |
| oss-experimental/react-dom/cjs/react-dom-client.production.js | = | 507.50 kB | 507.50 kB | = | 90.96 kB | 90.96 kB |
| facebook-www/ReactDOM-prod.classic.js | = | 595.40 kB | 595.40 kB | = | 105.60 kB | 105.60 kB |
| facebook-www/ReactDOM-prod.modern.js | = | 571.70 kB | 571.70 kB | = | 101.80 kB | 101.80 kB |
Significant size changes
Includes any change greater than 0.2%:
(No significant changes)
Generated by :no_entry_sign: dangerJS against 0fee2e8ea6af4ba7032397150b1cf098dffec986
cc @rickhanlonii
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!