react
react copied to clipboard
Fix:- fixed higherPriorityLane call & added a few test to the fibre lane
Just going through the codebase and going through the fibrelane there were no test, so i tried to write a few initial covering test from my understanding of the file, while writing the test found a small error in the higherPriorityLane call, If
the second argument is NoLane, it returns NoLane instead of returning the first given lane.
cc @sebmarkbage @acdlite @eps1lon
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-compiler-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 27, 2024 4:58pm |
Comparing: 3f1436cca1f8dd80a19fd52b97b6ff71a4d9ce82...c6a9692d7270d7645e6279284f3523d129738389
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.js | = | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB |
| oss-stable/react-dom/cjs/react-dom-client.production.js | +0.02% | 495.01 kB | 495.11 kB | +0.01% | 88.68 kB | 88.69 kB |
| oss-experimental/react-dom/cjs/react-dom.production.js | = | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB |
| oss-experimental/react-dom/cjs/react-dom-client.production.js | +0.02% | 499.81 kB | 499.91 kB | +0.01% | 89.36 kB | 89.37 kB |
| facebook-www/ReactDOM-prod.classic.js | +0.02% | 592.16 kB | 592.27 kB | +0.01% | 104.15 kB | 104.17 kB |
| facebook-www/ReactDOM-prod.modern.js | +0.02% | 568.39 kB | 568.49 kB | +0.01% | 100.55 kB | 100.56 kB |
| test_utils/ReactAllWarnings.js | Deleted | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB |
Significant size changes
Includes any change greater than 0.2%:
Expand to show
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| test_utils/ReactAllWarnings.js | Deleted | 64.26 kB | 0.00 kB | Deleted | 16.02 kB | 0.00 kB |
Generated by :no_entry_sign: dangerJS against c6a9692d7270d7645e6279284f3523d129738389
@rickhanlonii could you help me gather some feedback around this?
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
cc @acdlite
This pull request has been automatically marked as stale. If this pull request is still relevant, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize reviewing it yet. Your contribution is very much appreciated.
Closing this pull request after a prolonged period of inactivity. If this issue is still present in the latest release, please ask for this pull request to be reopened. Thank you!