react icon indicating copy to clipboard operation
react copied to clipboard

Export `version` from `react-dom` entry with `react-server` condition

Open unstubbable opened this issue 1 year ago • 3 comments

Summary

By exporting the version for this entry we can avoid this workaround in Next.js: https://github.com/vercel/next.js/blob/0f55f2ab1da5ee98b39316b4790734dd92ccc5bc/packages/next/src/server/future/route-modules/app-page/vendored/rsc/entrypoints.ts#L73-L79

How did you test this change?

I ran RELEASE_CHANNEL=stable node scripts/rollup/build.js --type=NODE_DEV and then inspected the contents of build/node_modules/react-dom/cjs/react-dom.react-server.development.js to verify that version is included in the exports.

unstubbable avatar May 27 '24 10:05 unstubbable

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 10:49am

vercel[bot] avatar May 27 '24 10:05 vercel[bot]

Comparing: ea6e05912aa43a0bbfbee381752caa1817a41a86...f69982c3f2e1c951a0d8c3cc4523c142497dcf13

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB +0.11% 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 496.04 kB 496.04 kB = 88.77 kB 88.77 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB +0.11% 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 500.84 kB 500.84 kB = 89.45 kB 89.46 kB
facebook-www/ReactDOM-prod.classic.js = 593.48 kB 593.48 kB = 104.38 kB 104.38 kB
facebook-www/ReactDOM-prod.modern.js = 569.87 kB 569.87 kB = 100.77 kB 100.77 kB
test_utils/ReactAllWarnings.js Deleted 63.82 kB 0.00 kB Deleted 15.95 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
oss-experimental/react-dom/cjs/react-dom.react-server.production.js +1.26% 4.84 kB 4.90 kB +4.04% 1.24 kB 1.29 kB
oss-stable/react-dom/cjs/react-dom.react-server.production.js +1.05% 4.84 kB 4.89 kB +3.47% 1.24 kB 1.28 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.production.js +0.58% 4.84 kB 4.87 kB +1.37% 1.24 kB 1.26 kB
oss-experimental/react-dom/cjs/react-dom.react-server.development.js +0.55% 17.38 kB 17.48 kB +1.57% 3.88 kB 3.94 kB
oss-stable/react-dom/cjs/react-dom.react-server.development.js +0.49% 17.31 kB 17.40 kB +1.43% 3.85 kB 3.91 kB
oss-stable-semver/react-dom/cjs/react-dom.react-server.development.js +0.36% 17.31 kB 17.37 kB +0.75% 3.85 kB 3.88 kB
test_utils/ReactAllWarnings.js Deleted 63.82 kB 0.00 kB Deleted 15.95 kB 0.00 kB

Generated by :no_entry_sign: dangerJS against f69982c3f2e1c951a0d8c3cc4523c142497dcf13

react-sizebot avatar May 27 '24 10:05 react-sizebot

Especially important since the workaround in Next.js will hide version mismatches.

eps1lon avatar May 27 '24 14:05 eps1lon