react
react copied to clipboard
Published
2 months ago
•
facebook
facebook
Current behavior for Effect behavior in StrictMode when reordering
Summary
Test for current behavior experienced in https://github.com/facebook/react/issues/29585.
How did you test this change?
-
yarn test --watch packages/react-reconciler/src/__tests__/StrictEffectsMode-test.js -t "effect invovation after key swap"
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-compiler-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 27, 2024 10:13am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Comparing: ea6e05912aa43a0bbfbee381752caa1817a41a86...f94b10fff401bf82db5bb3a7cc0abe14d97869b8
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.js | = | 6.66 kB | 6.66 kB | +0.05% | 1.82 kB | 1.82 kB |
| oss-stable/react-dom/cjs/react-dom-client.production.js | = | 496.04 kB | 496.04 kB | = | 88.77 kB | 88.77 kB |
| oss-experimental/react-dom/cjs/react-dom.production.js | = | 6.67 kB | 6.67 kB | +0.05% | 1.83 kB | 1.83 kB |
| oss-experimental/react-dom/cjs/react-dom-client.production.js | = | 500.84 kB | 500.84 kB | = | 89.45 kB | 89.46 kB |
| facebook-www/ReactDOM-prod.classic.js | = | 593.48 kB | 593.48 kB | = | 104.38 kB | 104.38 kB |
| facebook-www/ReactDOM-prod.modern.js | = | 569.87 kB | 569.87 kB | = | 100.77 kB | 100.77 kB |
| test_utils/ReactAllWarnings.js | Deleted | 63.82 kB | 0.00 kB | Deleted | 15.95 kB | 0.00 kB |
Significant size changes
Includes any change greater than 0.2%:
Expand to show
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| test_utils/ReactAllWarnings.js | Deleted | 63.82 kB | 0.00 kB | Deleted | 15.95 kB | 0.00 kB |
Generated by :no_entry_sign: dangerJS against f94b10fff401bf82db5bb3a7cc0abe14d97869b8
Do we want to rephrase the PR title? From
Current behavior for Effect behavior in StrictMode when reordering #29595
To
Added tests highlighting useEffect behavior during reordering in StrictMode
