react icon indicating copy to clipboard operation
react copied to clipboard

compiler: Add todo for getter/setter syntax

Open josephsavona opened this issue 1 year ago • 3 comments

Stack from ghstack (oldest at bottom):

  • -> #29592
  • #29591

We were missing a check that ObjectMethods are not getters or setters. In our experience this is pretty rare within React components and hooks themselves, so let's start with a todo.

Closes #29586

josephsavona avatar May 25 '24 21:05 josephsavona

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 25, 2024 9:29pm

vercel[bot] avatar May 25 '24 21:05 vercel[bot]

Comparing: b078c810c787cf13d9bd1958f083b4e3a162a720...9bd33c975c73ffd436baefc9ecd4fd094cc48be6

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.66 kB 6.66 kB = 1.82 kB 1.82 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 496.04 kB 496.04 kB = 88.77 kB 88.77 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.67 kB 6.67 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 500.84 kB 500.84 kB = 89.46 kB 89.46 kB
facebook-www/ReactDOM-prod.classic.js = 593.48 kB 593.48 kB = 104.38 kB 104.38 kB
facebook-www/ReactDOM-prod.modern.js = 569.87 kB 569.87 kB = 100.77 kB 100.77 kB
test_utils/ReactAllWarnings.js Deleted 63.82 kB 0.00 kB Deleted 15.95 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 63.82 kB 0.00 kB Deleted 15.95 kB 0.00 kB

Generated by :no_entry_sign: dangerJS against 9bd33c975c73ffd436baefc9ecd4fd094cc48be6

react-sizebot avatar May 25 '24 21:05 react-sizebot

Note that #29593 shows why it isn't safe to just enable support for get/set syntax today (not without assuming that developers follow the rules, at least).

josephsavona avatar May 25 '24 22:05 josephsavona