facebook
[Fiber] Use Owner/JSX Stack When Appending Stacks to Console
This one should be fully behind the enableOwnerStacks flag.
Instead of printing the parent Component stack all the way to the root, this now prints the owner stack of every JSX callsite. It also includes intermediate callsites between the Component and the JSX call so it has potentially more frames. Mainly it provides the line number of the JSX callsite. In terms of the number of components is a subset of the parent component stack so it's less information in that regard. This is usually better since it's more focused on components that might affect the output but if it's contextual based on rendering it's still good to have parent stack. Therefore, I still use the parent stack when printing DOM nesting warnings but I plan on switching that format to a diff view format instead (Next.js already reformats the parent stack like this).
Follow ups
-
Server Components show up in the owner stack for client logs but logs done by Server Components don't yet get their owner stack printed as they're replayed. They're also not yet printed in the server logs of the RSC server.
-
Server Component stack frames are formatted as the server and added to the end but this might be a different format than the browser. E.g. if server is running V8 and browser is running JSC or vice versa. Ideally we can reformat them in terms of the client formatting.
-
This doesn't yet update Fizz or DevTools. Those will be follow ups. Fizz still prints parent stacks in the server side logs. The stacks added to user space
console.errorcalls by DevTools still get the parent stacks instead. -
It also doesn't yet expose these to user space so there's no way to get them inside
onCaughtErrorfor example or inside a customconsole.erroroverride. -
In another follow up I'll use
console.createTaskinstead and completely remove these stacks if it's available.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-compiler-playground | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | May 23, 2024 4:57pm |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Comparing: 84239da896fd7395a667ab1e7ef1ef338a32de8f...65d16bbe42fa6dc82a754b13bc690bbe3c70e88b
Critical size changes
Includes critical production bundles, as well as any change greater than 2%:
| Name | +/- | Base | Current | +/- gzip | Base gzip | Current gzip |
|---|---|---|---|---|---|---|
| oss-stable/react-dom/cjs/react-dom.production.js | = | 6.66 kB | 6.66 kB | = | 1.82 kB | 1.82 kB |
| oss-stable/react-dom/cjs/react-dom-client.production.js | +0.02% | 495.90 kB | 495.99 kB | = | 88.79 kB | 88.79 kB |
| oss-experimental/react-dom/cjs/react-dom.production.js | = | 6.67 kB | 6.67 kB | = | 1.83 kB | 1.83 kB |
| oss-experimental/react-dom/cjs/react-dom-client.production.js | +0.02% | 500.70 kB | 500.79 kB | = | 89.47 kB | 89.48 kB |
| facebook-www/ReactDOM-prod.classic.js | +0.02% | 593.46 kB | 593.55 kB | = | 104.41 kB | 104.41 kB |
| facebook-www/ReactDOM-prod.modern.js | +0.02% | 569.84 kB | 569.93 kB | = | 100.80 kB | 100.80 kB |
| test_utils/ReactAllWarnings.js | Deleted | 64.27 kB | 0.00 kB | Deleted | 16.06 kB | 0.00 kB |
Significant size changes
Includes any change greater than 0.2%:
Expand to show
Generated by :no_entry_sign: dangerJS against 65d16bbe42fa6dc82a754b13bc690bbe3c70e88b
