fix: path handling in react devtools

[Jack-Works]

Summary

Fix how devtools handles URLs. It

• cannot handle relative source map URLs //# sourceMappingURL=x.map
• cannot recognize Windows style URLs

How did you test this change?

works on my side

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
react-compiler-playground	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jul 3, 2024 7:36am

[Jack-Works]

hi please review this again thanks cc @hoxyq

[hoxyq]

hi please review this again thanks cc @hoxyq

Hey, I don't see anything wrong with this approach, but I need to test it manually, for which I don't have time at the moment. Can I ask you to add 1-2 test cases for symbolicateSource function, which will demonstrate that this implementation fixes the cases, which are mentioned in the description of this PR?

[Jack-Works]

hi please review this again thanks cc @hoxyq

Hey, I don't see anything wrong with this approach, but I need to test it manually, for which I don't have time at the moment. Can I ask you to add 1-2 test cases for symbolicateSource function, which will demonstrate that this implementation fixes the cases, which are mentioned in the description of this PR?

Hi! Current symbolicateSource (or the component using it) doesn't have any test cases, so I have no idea where to add it

[hoxyq]

hi please review this again thanks cc @hoxyq

Hey, I don't see anything wrong with this approach, but I need to test it manually, for which I don't have time at the moment. Can I ask you to add 1-2 test cases for symbolicateSource function, which will demonstrate that this implementation fixes the cases, which are mentioned in the description of this PR?

Hi! Current symbolicateSource (or the component using it) doesn't have any test cases, so I have no idea where to add it

You can add it to packages/react-devtools-shared/src/__tests__. You would need to export symbolicateSource function and use it it in your Jest test cases.

[Jack-Works]

hi please review this again thanks cc @hoxyq

Hey, I don't see anything wrong with this approach, but I need to test it manually, for which I don't have time at the moment. Can I ask you to add 1-2 test cases for symbolicateSource function, which will demonstrate that this implementation fixes the cases, which are mentioned in the description of this PR?

Hi! Current symbolicateSource (or the component using it) doesn't have any test cases, so I have no idea where to add it

You can add it to packages/react-devtools-shared/src/__tests__. You would need to export symbolicateSource function and use it it in your Jest test cases.

hello! How can I run the test? I tried yarn test --testPathPattern=react-devtools-shared but 0 tests hit

[hoxyq]

hi please review this again thanks cc @hoxyq

Hey, I don't see anything wrong with this approach, but I need to test it manually, for which I don't have time at the moment. Can I ask you to add 1-2 test cases for symbolicateSource function, which will demonstrate that this implementation fixes the cases, which are mentioned in the description of this PR?

Hi! Current symbolicateSource (or the component using it) doesn't have any test cases, so I have no idea where to add it

You can add it to packages/react-devtools-shared/src/__tests__. You would need to export symbolicateSource function and use it it in your Jest test cases.

hello! How can I run the test? I tried yarn test --testPathPattern=react-devtools-shared but 0 tests hit

Try running this from root folder - yarn test --build --project=devtools -r=experimental --ci packages/react-devtools-shared/src/__tests__/<your-test-name>

[Jack-Works]

hi @hoxyq I have added tests, please take a look thanks!

[hoxyq]

Thanks!